Support older pika versions #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
nikosokolik and
oxeye-nikolay
and removed request for
a team
...entelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/pika_instrumentor.py
Outdated
Show resolved
Hide resolved
...entelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/pika_instrumentor.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-pika/tests/test_pika_instrumentation.py
Outdated
Show resolved
Hide resolved
nozik
force-pushed
the
support_older_pika_versions
branch
from
1f8882b to
52e6330
Compare
...entelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/pika_instrumentor.py
Outdated
Show resolved
Hide resolved
nozik
force-pushed
the
support_older_pika_versions
branch
from
52e6330 to
fdba606
Compare
nozik
force-pushed
the
support_older_pika_versions
branch
2 times, most recently
from
bc01feb to
26399c3
Compare
nozik
force-pushed
the
support_older_pika_versions
branch
from
26399c3 to
29fbd93
Compare
nozik
force-pushed
the
support_older_pika_versions
branch
from
29fbd93 to
e85a2c8
Compare
oxeye-nikolay
approved these changes
Dec 21, 2021
owais
approved these changes
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
opentelemetry-instrumentation-pikasupports onlypikaversions above1.0.0. This PR adds support topika >= 0.12.0Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've updated
tox.inito include tests for the olderpikaversions.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.